Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update or replace django-storages #44

Closed
Jawayria opened this issue Jul 27, 2021 · 9 comments
Closed

Update or replace django-storages #44

Jawayria opened this issue Jul 27, 2021 · 9 comments
Assignees
Labels
outdated dependency A dependency needs to be updated or replaced to support an upgrade initiative

Comments

@Jawayria
Copy link

We use the package django-storages in edx/blockstore, edx/course-discovery, edx/credentials, edx/edx-analytics-data-api, edx/edx-platform, edx/edx-val, edx/portal-designer, edx/registrar, edx/xqueue. It hasn't yet added support for Django3.2. Please follow the guidance in https://openedx.atlassian.net/wiki/spaces/AC/pages/3036972032/Handling+Outdated+Dependencies to resolve the problem this poses for the Open edX Django 3.2 upgrade.

@Jawayria Jawayria added the outdated dependency A dependency needs to be updated or replaced to support an upgrade initiative label Jul 27, 2021
@mariajgrimaldi
Copy link

Hello @natabene, I hope you're doing great!

I'll be looking into this issue soon. Would you assign it to me?

@natabene
Copy link

@mariajgrimaldi Thank you so much for reaching out, I appreciate. Sure, I will assign to you. Please keep me posted on progress and let me know once this is done.

@mariajgrimaldi
Copy link

A quick update:

After some research, I found two essential -open- PRs that can help with the Django 3.2 support:

To prove that those PRs are enough to support Django 3.2, I cherry-picked them to a separate branch and triggered testing via Travis CI: https://github.com/mariajgrimaldi/django-storages/runs/3509577400

All tests passed, including those using Django 3.2.

I reached out to them in PR #1005 and with a repository issue to help them move forward, but they haven't answered yet. Is there anything we could do besides waiting?

@natabene
Copy link

natabene commented Sep 7, 2021

@mariajgrimaldi Thank you for an update. Let's wait some more.

@mariajgrimaldi
Copy link

mariajgrimaldi commented Sep 7, 2021

I opened this PR that migrates Travis CI to Github actions and adds Django 3.2 support, and it was merged today!
I'm waiting for a response to this comment where I'm asking for the release. Let's see :)

@natabene
Copy link

natabene commented Sep 8, 2021

@mariajgrimaldi Thanks for sharing great news. Hoping for the best with the rest of it.

@mariajgrimaldi
Copy link

Hi there! I've been checking this issue every other day, and they haven't done the version bump. Either way, master already has support for Django 3.2!

@mariajgrimaldi
Copy link

Hi there @natabene! The new release is out https://pypi.org/project/django-storages/1.12/

@natabene
Copy link

natabene commented Oct 7, 2021

Thanks so much for the update, @mariajgrimaldi !

@natabene natabene closed this as completed Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outdated dependency A dependency needs to be updated or replaced to support an upgrade initiative
Projects
None yet
Development

No branches or pull requests

3 participants