Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update or replace django-nose #68

Closed
Jawayria opened this issue Jul 27, 2021 · 11 comments
Closed

Update or replace django-nose #68

Jawayria opened this issue Jul 27, 2021 · 11 comments
Assignees
Labels
outdated dependency A dependency needs to be updated or replaced to support an upgrade initiative

Comments

@Jawayria
Copy link

We use the package django-nose in edx/ubcpi, edx/xblock-in-video-quiz. It hasn't yet added support for Django3.2. Please follow the guidance in https://openedx.atlassian.net/wiki/spaces/AC/pages/3036972032/Handling+Outdated+Dependencies to resolve the problem this poses for the Open edX Django 3.2 upgrade.

@Jawayria Jawayria added the outdated dependency A dependency needs to be updated or replaced to support an upgrade initiative label Jul 27, 2021
@ghassanmas
Copy link

I have just asked the orignal author for the repo, about how to move forward in order to upgarde it.
Also for context worth qouting from the repo Readme.md

nose has been in maintenance mode since at least 2015. django-nose is in maintenance mode as well, and the sole maintainer is no longer an active user. See Jazzband.co to learn how django-nose is maintained and how you can help. New projects should consider using pytest, or unittest with the Django testing framework.

@jmbowman
Copy link

Yeah, I'm surprised there's still any usage of this; I thought we had it all replaced with pytest already. I'm still figuring out if we can deprecate our ubcpi fork, do you have any interest in porting xblock-in-video-quiz over to use pytest instead? There are a few Jira tickets explaining how to do this for other repos.

@ghassanmas
Copy link

@jmbowman I am currently in the process of migrating to pytest. The eample you sent seems helpful and relevant!.
Just one note, to be clear there doesn't seems to be tests in the repo xblock-in-video-quiz right?, or am I missing somehting...

ghassanmas added a commit to ghassanmas/xblock-in-video-quiz that referenced this issue Sep 9, 2021
this commit is part of part of supporting Django 3.2
upgrade, for more context: edx/upgrades#68, the changes are:
1. Removing nose as a tool for testing
2. Adding pytest as the alternative
3. Updating the requirments to reflect 1 and 2
4  Adding a test which tests the deafult value of the Xblock model
@awais786
Copy link

@natabene you can close this. Its completed.

@ghassanmas
Copy link

edx/ubcpi still uses django-nose as it appears here: https://github.com/edx/ubcpi/blob/29f066d2397383297312cb49eb62718fe0514d99/requirements/test.txt#L6 .

@natabene
Copy link

@awais786 What do you think regarding the last comment?

@awais786
Copy link

I only checked xblock-in-video-quiz and it was done, but edx/ubcpi need updation.
@ghassanmas needs similar PR in edx/ubcpi also.

https://github.com/edx/ubcpi/blob/29f066d2397383297312cb49eb62718fe0514d99/settings/test.py#L34

@ghassanmas
Copy link

Alright, here is an update:

edx/ubcpi depends on edx/edx-submissions, now edx-submissions is in itself dones't seem upgrade.add to that, that to be able to text ubcpi on Django 3.2, we need to make sure edx-submissions is in itself compitable with 3.2, and for that to happen we first need to close #35 and #14 since both aim at making edx-submissions compitable with 3.2.

Summary: #35 and #14 are blockers to close this

@UsamaSadiq
Copy link
Member

@ghassanmas an update for edx/edx-submissions, edx-submissions==3.3.0 has already added Django 3.2 support in it.

@UsamaSadiq
Copy link
Member

@ghassanmas both #35 and #14 have been closed now with Django 3.2 support. Please let me know if we can now continue working on edx/ubcpi upgrade since the blockers have been resolved now.
Thanks.

@UsamaSadiq
Copy link
Member

edx/ubcpi has now been archived since the upstream repo is being used now in edX.
@ghassanmas thanks for your efforts on this. I'll close this issue now since it has been completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outdated dependency A dependency needs to be updated or replaced to support an upgrade initiative
Projects
None yet
Development

No branches or pull requests

6 participants