-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update or replace django-nose #68
Comments
I have just asked the orignal author for the repo, about how to move forward in order to upgarde it.
|
Yeah, I'm surprised there's still any usage of this; I thought we had it all replaced with pytest already. I'm still figuring out if we can deprecate our ubcpi fork, do you have any interest in porting xblock-in-video-quiz over to use pytest instead? There are a few Jira tickets explaining how to do this for other repos. |
@jmbowman I am currently in the process of migrating to |
this commit is part of part of supporting Django 3.2 upgrade, for more context: edx/upgrades#68, the changes are: 1. Removing nose as a tool for testing 2. Adding pytest as the alternative 3. Updating the requirments to reflect 1 and 2 4 Adding a test which tests the deafult value of the Xblock model
@natabene you can close this. Its completed. |
edx/ubcpi still uses django-nose as it appears here: https://github.com/edx/ubcpi/blob/29f066d2397383297312cb49eb62718fe0514d99/requirements/test.txt#L6 . |
@awais786 What do you think regarding the last comment? |
I only checked https://github.com/edx/ubcpi/blob/29f066d2397383297312cb49eb62718fe0514d99/settings/test.py#L34 |
Alright, here is an update: edx/ubcpi depends on edx/edx-submissions, now edx-submissions is in itself dones't seem upgrade.add to that, that to be able to text ubcpi on Django 3.2, we need to make sure edx-submissions is in itself compitable with 3.2, and for that to happen we first need to close #35 and #14 since both aim at making edx-submissions compitable with 3.2. |
@ghassanmas an update for edx/edx-submissions, edx-submissions==3.3.0 has already added |
@ghassanmas both #35 and #14 have been closed now with |
edx/ubcpi has now been archived since the upstream repo is being used now in edX. |
We use the package django-nose in edx/ubcpi, edx/xblock-in-video-quiz. It hasn't yet added support for Django3.2. Please follow the guidance in https://openedx.atlassian.net/wiki/spaces/AC/pages/3036972032/Handling+Outdated+Dependencies to resolve the problem this poses for the Open edX Django 3.2 upgrade.
The text was updated successfully, but these errors were encountered: