Support parsing resource changes in plan #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 515
💛 - Coveralls |
|
The travis-ci build seems to be failing for reasons unrelated to this PR. Let me know if that isn't the case and I can fix it. |
|
Thanks for the PR @dylanhellems 🎉 Will fix Travis CI, update your branch and merge it asap. |
eerkunt
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run into a couple of situations where non-compliant resources are not caught because they don't show up in the
planned_changesblock of the output file. Parsing theresource_changesblock in the terraform plan output seems to fix the issue. Seems like this was something that was planned anyway from the TODO.