Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster mounting #346

Merged
merged 5 commits into from
Aug 12, 2020
Merged

Conversation

Kudbettin
Copy link
Member

Large plan files with lots of references may take too much time to mount.
Following is an attempt to reduce it. (Processing my plan file went from taking 90 seconds to 4 seconds)

Using raw_resources instead of resources to prevent having too much information within the resources. (i.e. discard nested mountings and cycle references)

I believe cycle referencing shouldn't be a problem. Older versions don't seem to fully support it, so I won't either. Example of how cycle references could be handled. (Changes the application behavior a bit.)

@coveralls
Copy link

coveralls commented Aug 12, 2020

Pull Request Test Coverage Report for Build 1183

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 57.369%

Files with Coverage Reduction New Missed Lines %
terraform_compliance/common/defaults.py 6 85.0%
Totals Coverage Status
Change from base Build 1179: 0.3%
Covered Lines: 1339
Relevant Lines: 2334

💛 - Coveralls

@Kudbettin Kudbettin requested a review from eerkunt August 12, 2020 10:37
@eerkunt eerkunt merged commit f0a2644 into terraform-compliance:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants