Refactoring for compatibility with newer ember-cli #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember-cli as of 3.4-beta has introduced changes that make it impossible for us to nicely emit the built dependencies via our own vendor and public trees, because it now considers those as inputs to the trees that we analyze, causing a circle.
This is, IMO, an architectural mistake in ember-cli, because there is no real data dependency circle. Rather, the true data-dependency graph is being lost due to the way all trees are being combined and then re-separated to create the packager hook.
So anyway, now we must monkey patch EmberApp instead. It's pretty non-invasive and the function we are patching has been stable for a long long time.
Closes #26.