Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add testcase #3

Merged
merged 2 commits into from
Jul 30, 2016
Merged

test: add testcase #3

merged 2 commits into from
Jul 30, 2016

Conversation

popomore
Copy link
Member

No description provided.

popomore
popomore reviewed Jul 29, 2016
View reviewed changes
lib/base_loader.js
@@ -248,6 +248,8 @@ class EggLoader {
const eggPath = this.eggPath;
const frameworkPaths = [];

addEggPath(this.options.customEgg);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个应该加回来

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个主要是给单测时候用的？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不是，默认入口要加上，会去重的。

@popomore
Copy link
Member Author

这个库是重构完再 public？

gxcsoccer
gxcsoccer reviewed Jul 29, 2016
View reviewed changes
lib/plugin_loader.js
@@ -225,15 +225,16 @@ module.exports = {
}

if (!config) {
this.options.logger.warn(`[egg:loader] pkg.eggPlugin is missing in ${pluginPackage}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const logger = this.options.logger; ?

@fengmk2
Copy link
Member

fengmk2 commented Jul 29, 2016

我觉得可以直接public了

@popomore
Copy link
Member Author

可以

fengmk2
fengmk2 reviewed Jul 29, 2016
View reviewed changes
test/load_extend.test.js
.expect(200, done);
});

it('当无法找到依赖时应该抛错', function() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title改成英文吧

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

@gxcsoccer
Copy link
Contributor

+1

@popomore
Copy link
Member Author

popomore commented Jul 30, 2016 •
edited
Loading

后面还有几个文件，这家星巴克 22 端口关了

@popomore
Copy link
Member Author

Maked it public.

@gxcsoccer
Copy link
Contributor

eslint 报错

@popomore
Copy link
Member Author

eslint 3.2 发布后弄挂了

eslint/eslint@95ea25a

@popomore
Copy link
Member Author

@gxcsoccer 改好了

popomore
popomore reviewed Jul 30, 2016
View reviewed changes
test/fixtures/egg/plugins/diamond/package.json
@@ -0,0 +1,5 @@
{
"eggPlugin": {
"name": "diamond"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些名词有问题么

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该没问题吧。。

@gxcsoccer gxcsoccer merged commit 95b0a3c into master Jul 30, 2016
@gxcsoccer gxcsoccer deleted the test branch July 30, 2016 05:48
@gxcsoccer
Copy link
Contributor

gxcsoccer commented Jul 30, 2016 •
edited
Loading

+ [email protected]

@popomore
Copy link
Member Author

加用例应该不用发版本

@popomore popomore restored the test branch October 17, 2016 09:42
@popomore popomore deleted the test branch December 19, 2016 09:38
fengmk2 added a commit that referenced this pull request Jan 13, 2023
@fengmk2
feat: support show app.timing in timline string
1a55c00 
```bash
egg start timeline:
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ [289ms] - #0 Process Start
                  ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ [510ms] - #1 Application Start
                  ▇ [2ms] - #2 Load Plugin
                  ▇ [1ms] - #3 Load Config
                  ▇ [0ms] - #4 Require(0) ~/eggjs/egg-core/test/fixtures/egg/config/config.default.js
                  ▇ [0ms] - #5 Require(1) ~/eggjs/egg-core/test/fixtures/egg/config/config.unittest.js
                  ▇ [0ms] - #6 Load extend/application.js
                  ▇ [0ms] - #7 Require(2) ~/eggjs/egg-core/test/fixtures/egg/app/extend/application.js
                  ▇ [1ms] - #8 Load extend/context.js
                  ▇ [0ms] - #9 Load extend/request.js
                  ▇ [0ms] - #10 Load extend/response.js
                  ▇ [1ms] - #11 Load app.js
                  ▇ [0ms] - #12 Require(3) ~/eggjs/egg-core/test/fixtures/egg/node_modules/session/app.js
                  ▇ [0ms] - #13 Require(4) app.js
                  ▇▇▇▇▇▇ [101ms] - #14 readyCallback in a
                  ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ [501ms] - #15 readyCallback in b
                  ▇ [4ms] - #16 Load Middleware
                  ▇ [4ms] - #17 Load "middlewares" to Application
                  ▇ [2ms] - #18 Load Service
                  ▇ [2ms] - #19 Load "service" to Context
                  ▇ [0ms] - #20 Load Controller
                  ▇ [0ms] - #21 Load "controller" to Application
                  ▇ [0ms] - #22 Load Router
```
fengmk2 added a commit that referenced this pull request Jan 13, 2023
@fengmk2
feat: support show app.timing in timline string (#260)
5b7af12 
```bash
egg start timeline:
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ [289ms] - #0 Process Start
                  ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ [510ms] - #1 Application Start
                  ▇ [2ms] - #2 Load Plugin
                  ▇ [1ms] - #3 Load Config
                  ▇ [0ms] - #4 Require(0) ~/eggjs/egg-core/test/fixtures/egg/config/config.default.js
                  ▇ [0ms] - #5 Require(1) ~/eggjs/egg-core/test/fixtures/egg/config/config.unittest.js
                  ▇ [0ms] - #6 Load extend/application.js
                  ▇ [0ms] - #7 Require(2) ~/eggjs/egg-core/test/fixtures/egg/app/extend/application.js
                  ▇ [1ms] - #8 Load extend/context.js
                  ▇ [0ms] - #9 Load extend/request.js
                  ▇ [0ms] - #10 Load extend/response.js
                  ▇ [1ms] - #11 Load app.js
                  ▇ [0ms] - #12 Require(3) ~/eggjs/egg-core/test/fixtures/egg/node_modules/session/app.js
                  ▇ [0ms] - #13 Require(4) app.js
                  ▇▇▇▇▇▇ [101ms] - #14 readyCallback in a
                  ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ [501ms] - #15 readyCallback in b
                  ▇ [4ms] - #16 Load Middleware
                  ▇ [4ms] - #17 Load "middlewares" to Application
                  ▇ [2ms] - #18 Load Service
                  ▇ [2ms] - #19 Load "service" to Context
                  ▇ [0ms] - #20 Load Controller
                  ▇ [0ms] - #21 Load "controller" to Application
                  ▇ [0ms] - #22 Load Router
```
atian25 pushed a commit that referenced this pull request Jan 13, 2023
@semantic-release-bot
Release 5.3.0
5cc4023 
[skip ci]

## [5.3.0](v5.2.0...v5.3.0) (2023-01-13)

### Features

* support show app.timing in timline string ([#260](#260)) ([5b7af12](5b7af12)), closes [#0](https://github.com/eggjs/egg-core/issues/0) [#1](#1) [#2](#2) [#3](#3) [#4](#4) [#5](#5) [#6](#6) [#7](#7) [#8](#8) [#9](#9) [#10](#10) [#11](#11) [#12](#12) [#13](#13) [#14](#14) [#15](#15) [#16](#16) [#17](#17) [#18](#18) [#19](#19) [#20](#20) [#21](#21) [#22](#22)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fengmk2 fengmk2

@gxcsoccer gxcsoccer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@popomore @fengmk2 @gxcsoccer