Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use posix join for package path #127

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Jun 28, 2023

Closes:

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (81176b6) 93.23% compared to head (7dd6651) 93.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files         219      219           
  Lines        4610     4610           
  Branches      466      466           
=======================================
  Hits         4298     4298           
  Misses        312      312           
Impacted Files Coverage Δ
core/common-util/src/ModuleConfig.ts 75.17% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@killagu killagu added this pull request to the merge queue Jun 28, 2023
Merged via the queue into master with commit 53672f4 Jun 28, 2023
@killagu killagu deleted the fix/windows_pkg_path branch June 28, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant