Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: after call mockModuleContext, hasMockModuleContext should be true #134

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

popomore
Copy link
Member

@popomore popomore commented Jul 13, 2023

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@popomore popomore requested a review from killagu July 13, 2023 03:44
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (6039fbc) 93.49% compared to head (ed9c122) 93.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   93.49%   93.51%   +0.02%     
==========================================
  Files         223      223              
  Lines        4657     4659       +2     
  Branches      473      499      +26     
==========================================
+ Hits         4354     4357       +3     
+ Misses        303      302       -1     
Impacted Files Coverage Δ
plugin/tegg/app/extend/application.unittest.ts 94.28% <100.00%> (+3.37%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killagu killagu added this pull request to the merge queue Jul 13, 2023
Merged via the queue into master with commit 88b3caa Jul 13, 2023
@killagu killagu deleted the fix-hasMockModuleContext branch July 13, 2023 05:06
@killagu
Copy link
Contributor

killagu commented Jul 13, 2023

3.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants