feat: implement RuntimeConfig #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get RuntimeConfig through RuntimeConfigUtil It contains - baseDir - env - name
popomore
force-pushed
the
RuntimeConfigUtil
branch
from
6842b45 to
a1e988e
Compare
popomore
changed the title
killagu
reviewed
Aug 23, 2023
| baseDir: string; | ||
| } | ||
|
|
||
| export class RuntimeConfigUtil { |
There was a problem hiding this comment.
这里应该只是一个定义
class RuntimeConfig {
name: string;
env: string;
baseDir: string;
}在具体的 runtime 中把这个类构造出来。
这样就能解决多个实例的问题了。
There was a problem hiding this comment.
所以这里还是类型注入的模式？用法就是
import type { RuntimeConfig } from '@alipay/tegg-common-util';
@SingletonProto()
class Example {
@Inject()
runtimeConfig: RuntimeConfig;
}
fengmk2
reviewed
Aug 24, 2023
plugin/tegg/app.ts
Outdated
| @@ -20,6 +21,11 @@ export default class App { | |||
| } | |||
|
|
|||
| configWillLoad() { | |||
| RuntimeConfigUtil.setRuntimeConfig({ | |||
popomore
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #144 +/- ##
=======================================
Coverage 93.76% 93.77%
=======================================
Files 227 227
Lines 4731 4738 +7
Branches 509 509
=======================================
+ Hits 4436 4443 +7
Misses 295 295
☔ View full report in Codecov by Sentry. |
|
LGTM |
fengmk2
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RuntimeConfig can be injected in tegg and standalone
It contains
Checklist
npm testpassesAffected core subsystem(s)
Description of change