Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eventbus): allow a handler to subscribe to multiple events #179

Merged
merged 4 commits into from
Dec 26, 2023
Merged

feat(eventbus): allow a handler to subscribe to multiple events #179

merged 4 commits into from
Dec 26, 2023

Conversation

YdreamW
Copy link
Contributor

@YdreamW YdreamW commented Dec 21, 2023

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

plugin/eventbus eventbus-decorator eventbus-runtime

Description of change

allow a handler to subscribe to multiple events

@fengmk2 fengmk2 requested a review from killagu December 21, 2023 14:23
@fengmk2 fengmk2 added the enhancement New feature or request label Dec 21, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 21, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (04fabef) 92.52% compared to head (598524e) 92.62%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
+ Coverage   92.52%   92.62%   +0.09%     
==========================================
  Files         235      236       +1     
  Lines        5020     5055      +35     
  Branches      539      544       +5     
==========================================
+ Hits         4645     4682      +37     
+ Misses        375      373       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@killagu
Copy link
Contributor

killagu commented Dec 26, 2023

🎉实现的非常好。感谢。

@YdreamW
Copy link
Contributor Author

YdreamW commented Dec 26, 2023

deprecated 的接口没覆盖到，覆盖率掉了，我补下单测

killagu
killagu approved these changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killagu killagu merged commit 1d460a5 into eggjs:master Dec 26, 2023
17 checks passed
@killagu
Copy link
Contributor

killagu commented Dec 26, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengmk2 fengmk2 fengmk2 left review comments

@killagu killagu killagu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YdreamW @killagu @fengmk2