Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scan framework dependencies as optional module #184

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Jan 16, 2024

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bc9d425) 92.62% compared to head (9866459) 93.99%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
+ Coverage   92.62%   93.99%   +1.37%     
==========================================
  Files         236      236              
  Lines        5055     5013      -42     
  Branches      544      541       -3     
==========================================
+ Hits         4682     4712      +30     
+ Misses        373      301      -72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@killagu killagu merged commit a4908c6 into master Jan 17, 2024
19 checks passed
@killagu killagu deleted the feat/optional_module branch January 17, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants