Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复aop丢失原引用,导致修改ctx的逻辑失效的问题 #187

Merged

Conversation

hwoarangzk
Copy link
Contributor

@hwoarangzk hwoarangzk commented Jan 24, 2024

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@fengmk2 fengmk2 added the bug Something isn't working label Jan 24, 2024
@fengmk2 fengmk2 requested a review from killagu January 24, 2024 07:42
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7ac47ca) 93.99% compared to head (6386dc7) 93.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #187   +/-   ##
=======================================
  Coverage   93.99%   93.99%           
=======================================
  Files         236      236           
  Lines        5012     5014    +2     
  Branches      541      541           
=======================================
+ Hits         4711     4713    +2     
  Misses        301      301           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killagu killagu merged commit 7656424 into eggjs:master Jan 25, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants