Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use loader to load TableClazzList #219

Merged
merged 1 commit into from
Apr 28, 2024
Merged

fix: use loader to load TableClazzList #219

merged 1 commit into from
Apr 28, 2024

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Apr 28, 2024 •
edited by coderabbitai bot
Loading

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Summary by CodeRabbit

  • Refactor
    • Enhanced the data loading process to improve efficiency and reliability.
    • Optimized the filtering mechanism for table classes to ensure more accurate data handling.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 28, 2024 •
edited
Loading

Walkthrough

The update brings in new imports and restructures data source management in DataSource.ts, improving how DAO and table classes are managed using LoaderFactory. The package.json in plugin/dal now includes globby to support these changes, ensuring smoother data operations and integration.

Changes

File Path Change Summary
.../lib/DataSource.ts Added imports from @eggjs/tegg/helper and @eggjs/tegg/dal, and revamped DAO class loading and table filtering logic.
.../package.json Added globby and updated @eggjs/dal-runtime dependency.

🐰✨
A hop, a skip, in the code we dive,
New imports arrive, making data thrive.
With globby in hand, and refactors so grand,
Our data flows smooth, across the land.
Cheers to changes, both big and small,
In the world of code, they matter to all! 🌟
🐰💻

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between ac91cdc and 224e550.
Files selected for processing (1)
  • plugin/dal/lib/DataSource.ts (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • plugin/dal/lib/DataSource.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@killagu killagu force-pushed the fix/dynamic_datasource_config branch from 0a2bd0e to 224e550 Compare April 28, 2024 12:10
killagu
killagu commented Apr 28, 2024
View reviewed changes
plugin/dal/lib/DataSource.ts
@@ -28,25 +34,12 @@ import { SqlMapManager } from './SqlMapManager';
const config = ModuleConfigUtil.loadModuleConfigSync(ctx.unitPath) as any | undefined;
const dataSources = Object.keys(config?.dataSource || {});
const result: ObjectInfo[] = [];
const daoDir = path.join(ctx.unitPath, 'dal/dao');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不应该 hard code 路径。

gxkl
gxkl approved these changes Apr 28, 2024
View reviewed changes
Copy link
Contributor

@gxkl gxkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@killagu killagu merged commit 15ef977 into master Apr 28, 2024
11 checks passed
@killagu killagu deleted the fix/dynamic_datasource_config branch April 28, 2024 12:25
@killagu
Copy link
Contributor Author

killagu commented Apr 28, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gxkl gxkl gxkl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@killagu @gxkl