Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize backgroud output #47

Merged
merged 3 commits into from
Aug 10, 2022
Merged

Conversation

whxaxes
Copy link
Member

@whxaxes whxaxes commented Aug 10, 2022

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

当 background task 超时后,如果读 egg 中的兼容对象,ctx 是 undefined ,错误比较误导人,所以加一下通用错误码。

@whxaxes whxaxes requested a review from killagu August 10, 2022 09:09
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #47 (21c3c71) into master (41b67b2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   91.89%   91.90%           
=======================================
  Files         198      198           
  Lines        4037     4040    +3     
  Branches      387      388    +1     
=======================================
+ Hits         3710     3713    +3     
  Misses        326      326           
  Partials        1        1           
Impacted Files Coverage Δ
plugin/tegg/lib/EggAppLoader.ts 98.63% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whxaxes whxaxes merged commit 6d978c5 into master Aug 10, 2022
@whxaxes whxaxes deleted the fix-optimize-backgroud-output branch August 10, 2022 09:55
@fengmk2 fengmk2 added bug Something isn't working enhancement New feature or request labels Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants