Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: eventbus runtime should wait all handlers done #51

Merged
merged 1 commit into from
Aug 24, 2022
Merged

fix: eventbus runtime should wait all handlers done #51

merged 1 commit into from
Aug 24, 2022

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Aug 24, 2022

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@killagu killagu added the bug Something isn't working label Aug 24, 2022
@killagu killagu force-pushed the fix/wait_all_handler_done branch from c515d5b to 09a0f8f Compare August 24, 2022 11:09
@codecov
Copy link

codecov bot commented Aug 24, 2022 •
edited
Loading

Codecov Report

Merging #51 (c515d5b) into master (12140fa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c515d5b differs from pull request most recent head 09a0f8f. Consider uploading reports for the commit 09a0f8f to get more accurate results

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   92.05%   92.06%           
=======================================
  Files         199      199           
  Lines        4117     4120    +3     
  Branches      399      399           
=======================================
+ Hits         3790     3793    +3     
  Misses        326      326           
  Partials        1        1
Impacted Files Coverage Δ
core/eventbus-runtime/src/SingletonEventBus.ts 78.43% <100.00%> (+1.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

whxaxes
whxaxes approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@whxaxes whxaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killagu killagu merged commit 0651d30 into master Aug 24, 2022
@killagu killagu deleted the fix/wait_all_handler_done branch August 24, 2022 11:20
@killagu
Copy link
Contributor Author

killagu commented Aug 24, 2022 

 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]
 - @eggjs/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whxaxes whxaxes whxaxes approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@killagu @whxaxes