Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: multi host decorator #68

Merged
merged 2 commits into from
Dec 15, 2022
Merged

feat: multi host decorator #68

merged 2 commits into from
Dec 15, 2022

Conversation

elrrrrrrr
Copy link
Contributor

@elrrrrrrr elrrrrrrr commented Dec 14, 2022 •
edited by fengmk2
Loading

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

controller-decorator

Description of change

Make the @Host decorator supports multiple host

@host(string) => @host(string | string[])

@codecov
Copy link

codecov bot commented Dec 14, 2022 •
edited
Loading

Codecov Report

Base: 92.20% // Head: 92.23% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (b0c471a) compared to base (4bba399).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
+ Coverage   92.20%   92.23%   +0.03%     
==========================================
  Files         217      217              
  Lines        4364     4368       +4     
  Branches      420      447      +27     
==========================================
+ Hits         4024     4029       +5     
+ Misses        339      338       -1     
  Partials        1        1
Impacted Files Coverage Δ
core/controller-decorator/src/model/types.ts 100.00% <ø> (ø)
...re/controller-decorator/src/decorator/http/Host.ts 100.00% <100.00%> (ø)
...corator/src/impl/http/HTTPControllerMetaBuilder.ts 95.83% <100.00%> (ø)
...r/src/impl/http/HTTPControllerMethodMetaBuilder.ts 94.44% <100.00%> (ø)
...ntroller-decorator/src/model/HTTPControllerMeta.ts 100.00% <100.00%> (ø)
...e/controller-decorator/src/model/HTTPMethodMeta.ts 95.00% <100.00%> (ø)
...ontroller-decorator/src/util/ControllerInfoUtil.ts 100.00% <100.00%> (ø)
...re/controller-decorator/src/util/MethodInfoUtil.ts 100.00% <100.00%> (ø)
...gin/controller/lib/impl/http/HTTPMethodRegister.ts 93.93% <100.00%> (+0.12%) ⬆️
plugin/controller/lib/RootProtoManager.ts 100.00% <0.00%> (+4.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

killagu
killagu approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elrrrrrrr elrrrrrrr force-pushed the multi-host branch 4 times, most recently from 805f6e8 to 5e7bdbb Compare December 15, 2022 08:16
@killagu killagu merged commit f6679de into eggjs:master Dec 15, 2022
@killagu
Copy link
Contributor

killagu commented Dec 15, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengmk2 fengmk2 fengmk2 left review comments

@killagu killagu killagu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elrrrrrrr @killagu @fengmk2