fix: cork/uncork should can be called multi times in same ctx #78

killagu · 2023-01-16T14:59:21Z

Checklist

npm test passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

Description of change

fengmk2 · 2023-01-16T16:23:13Z

plugin/eventbus/lib/EggContextEventBus.ts

@@ -28,6 +28,8 @@ export class EggContextEventBus implements ContextEventBus {
  uncork() {
    assert(this.corkId, 'eventbus uncork without cork');
    this.eventBus.uncork(this.corkId);
+    this.context.set(CORK_ID, null);


看来是一直都有问题？

是的。之前没测试过多次的场景

fix: cork/uncork should can be called multi times in same ctx

1f5fb8f

killagu force-pushed the fix/cork_multi_times branch from 4a208cf to 1f5fb8f Compare January 16, 2023 15:14

killagu merged commit 269cda6 into master Jan 16, 2023

killagu deleted the fix/cork_multi_times branch January 16, 2023 15:25

fengmk2 reviewed Jan 16, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: cork/uncork should can be called multi times in same ctx #78

fix: cork/uncork should can be called multi times in same ctx #78

killagu commented Jan 16, 2023

fengmk2 Jan 16, 2023

killagu Jan 17, 2023

fix: cork/uncork should can be called multi times in same ctx #78

fix: cork/uncork should can be called multi times in same ctx #78

Conversation

killagu commented Jan 16, 2023

Checklist

Affected core subsystem(s)

Description of change

fengmk2 Jan 16, 2023

Choose a reason for hiding this comment

killagu Jan 17, 2023

Choose a reason for hiding this comment