Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: router type #83

Merged
merged 2 commits into from
Jan 23, 2023
Merged

fix: router type #83

merged 2 commits into from
Jan 23, 2023

Conversation

elrrrrrrr
Copy link
Contributor

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • 修复 plugin/controller CI 报错
Description of change
  • 更新 type 定义,统一使用 egg 提供的 Router 类型
  • 不再使用 router.url 字段

@codecov
Copy link

codecov bot commented Jan 22, 2023

Codecov Report

Base: 92.54% // Head: 92.54% // No change to project coverage 👍

Coverage data is based on head (b721a6b) compared to base (641cd16).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   92.54%   92.54%           
=======================================
  Files         212      212           
  Lines        4455     4455           
  Branches      454      454           
=======================================
  Hits         4123     4123           
  Misses        332      332           
Impacted Files Coverage Δ
...controller/lib/impl/http/HTTPControllerRegister.ts 100.00% <100.00%> (ø)
...gin/controller/lib/impl/http/HTTPMethodRegister.ts 93.87% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fengmk2 fengmk2 merged commit b32d9b8 into eggjs:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants