Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add app.eggContextHandler #84

Merged
merged 1 commit into from
Jan 28, 2023
Merged

feat: add app.eggContextHandler #84

merged 1 commit into from
Jan 28, 2023

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Jan 28, 2023

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Base: 92.54% // Head: 92.54% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a455e58) compared to base (641cd16).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   92.54%   92.54%           
=======================================
  Files         212      212           
  Lines        4455     4456    +1     
  Branches      454      454           
=======================================
+ Hits         4123     4124    +1     
  Misses        332      332           
Impacted Files Coverage Δ
plugin/tegg/app.ts 100.00% <100.00%> (ø)
...gin/controller/lib/impl/http/HTTPMethodRegister.ts 93.87% <0.00%> (ø)
...controller/lib/impl/http/HTTPControllerRegister.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@killagu killagu merged commit 2772624 into master Jan 28, 2023
@killagu killagu deleted the feat/eggContextHandler branch January 28, 2023 03:52
@@ -22,6 +22,7 @@ export default class App {

configDidLoad() {
this.eggContextHandler = new EggContextHandler(this.app);
this.app.eggContextHandler = this.eggContextHandler;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

循环依赖不会有问题吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个问题不大,只有一个的。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants