Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wait egg background task done before destroy tegg ctx #87

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Jan 29, 2023

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@killagu killagu changed the title feat: wait egg background task done before destroy tegg ctx fix: wait egg background task done before destroy tegg ctx Jan 29, 2023
@killagu killagu force-pushed the feat/runInBackground branch from 08bb9e8 to 16fda00 Compare January 29, 2023 10:16
@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Base: 92.74% // Head: 92.77% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (16fda00) compared to base (6b31708).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   92.74%   92.77%   +0.02%     
==========================================
  Files         214      214              
  Lines        4492     4509      +17     
  Branches      459      459              
==========================================
+ Hits         4166     4183      +17     
  Misses        326      326              
Impacted Files Coverage Δ
plugin/tegg/app.ts 100.00% <100.00%> (ø)
plugin/tegg/lib/EggContextCompatibleHook.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@killagu killagu merged commit deea4d8 into master Jan 29, 2023
@killagu killagu deleted the feat/runInBackground branch January 29, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant