feat: use singleton model insteadof context #89
Conversation
Codecov ReportBase: 92.75% // Head: 92.75% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #89 +/- ##
=======================================
Coverage 92.75% 92.75%
=======================================
Files 214 214
Lines 4512 4512
Branches 460 458 -2
=======================================
Hits 4185 4185
Misses 327 327
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
加个 tracer 的单测，保证下 ctx 正常工作吧。 |
Singleton 里可以获取到当前上下文的。 |
|
就看 leoric emit 出来的事件，ctx 是否正常。 |
elrrrrrrr
force-pushed
the
singleton-orm
branch
from
aa2c232 to
6890d46
Compare
|
👌🏻 之前理解错了 我以为要同时支持 context 和 singleton 注入 |
| import { EGG_CONTEXT } from '@eggjs/egg-module-common'; | ||
|
|
||
| export class ContextModeObject implements EggObject { | ||
| export class SingletonModelObject implements EggObject { |
There was a problem hiding this comment.
命名改为 Model 之前似乎是 typo
| @@ -36,13 +40,13 @@ export class ContextModeObject implements EggObject { | |||
| } | |||
|
|
|||
| static get ctx() { | |||
| return ctx?.get(EGG_CONTEXT); | |||
| return self.getContext(); | |||
There was a problem hiding this comment.
需要改为实时获取，防止 Model 在不同 Service 中通过不同 ContextProto 或 SingletonProto 引入
elrrrrrrr
force-pushed
the
singleton-orm
branch
from
2a7dcae to
f674b2e
Compare
elrrrrrrr
force-pushed
the
singleton-orm
branch
from
f674b2e to
dff0a1f
Compare
Checklist
npm testpassesAffected core subsystem(s)
Description of change
Adherence to the principles of tegg@3.
Use Singleton instead of Context for @model.