fix: loader should not deps metadata #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killagu
force-pushed
the
deps/loader_metadata
branch
3 times, most recently
from
1d8d9b2 to
ba003ed
Compare
killagu
force-pushed
the
deps/loader_metadata
branch
from
ba003ed to
df2c482
Compare
Codecov ReportBase: 92.92% // Head: 92.91% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #94 +/- ##
==========================================
- Coverage 92.92% 92.91% -0.01%
==========================================
Files 217 217
Lines 4549 4548 -1
Branches 472 472
==========================================
- Hits 4227 4226 -1
Misses 322 322
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fengmk2
reviewed
Feb 9, 2023
| @@ -5,7 +5,7 @@ import { LoaderUtil } from '../LoaderUtil'; | |||
|
|
|||
| import { EggProtoImplClass } from '@eggjs/core-decorator'; | |||
| import { LoaderFactory } from '../LoaderFactory'; | |||
| import { EggLoadUnitType, Loader } from '@eggjs/tegg-metadata'; | |||
| import type { Loader } from '@eggjs/tegg-metadata'; | |||
There was a problem hiding this comment.
哈哈，看代码的人脑袋要转弯才明白 type 只需要通过 devDeps 引入 @eggjs/tegg-metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change