Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't jump to encoded character hash #212

Closed
mcdoyaji opened this issue Apr 4, 2019 · 3 comments
Closed

can't jump to encoded character hash #212

mcdoyaji opened this issue Apr 4, 2019 · 3 comments
Labels

Comments

@mcdoyaji
Copy link
Contributor

mcdoyaji commented Apr 4, 2019

I clicked [sidebar](./options#사이드바) hash link.

but, url link encoded.

sidebar

so I Got result below.

×
Unhandled Rejection (SyntaxError): Failed to execute 'querySelector' on 'Document': '#%EC%82%AC%EC%9D%B4%EB%93%9C%EB%B0%94' is not a valid selector.
VueComponent.jumpToHash

so, I edit jumpToHash() to get Decoded string.

    jumpToHash() {
      const {hash} = decodeURI(this.$route)
      if (hash) {

now, no more '9C%EB%B0%94' is not a valid selector. but still It's not jump to hash position.

I think that jump.js can't recognize hash position.

@egoist
Copy link
Owner

egoist commented Apr 4, 2019

Yeah we need to decodeURIComponent, PR welcome.

@mcdoyaji
Copy link
Contributor Author

mcdoyaji commented Apr 4, 2019

ah-ha.
const hash = decodeURI(this.$route.hash) works.

I'll PR soon. Thanks to make this nice program!

@egoist egoist closed this as completed in 9d2826c Apr 5, 2019
@egoist
Copy link
Owner

egoist commented Apr 5, 2019

🎉 This issue has been resolved in version 4.13.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@egoist egoist added the released label Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants