Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no_grad breaks reconstruction tutorial #274

Closed
eigenvivek opened this issue Jun 15, 2024 · 1 comment · Fixed by #275
Closed

no_grad breaks reconstruction tutorial #274

eigenvivek opened this issue Jun 15, 2024 · 1 comment · Fixed by #275

Comments

@eigenvivek
Copy link
Owner

Need to remove this line

with torch.no_grad():
img = _get_voxel(volume, xyzs, self.mode, align_corners=align_corners)

@eigenvivek
Copy link
Owner Author

eigenvivek commented Jun 15, 2024

2D/3D registration (optimizers.ipynb) works with no_grad but 3D reconstruction (reconstruction.ipynb) fails.

no_grad buys an additional 6-7 iterations / second.

Instead, add a flag to toggle the no_grad call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant