You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This was added in https://github.com/eisop/checker-framework/commit/b420748ca3299785218f657cad76fa9963b78a30
Looking at what framework/src/main/java/org/checkerframework/framework/type/TypeFromExpressionVisitor.java method visitMethodInvocation does now, I think this can always be removed.
I still find it ugly that the TypeFromExpressionVisitor does the capturing and asUse, which logically I would expect to happen in methodFromUse.
Please file an issue that we clean this up further. In this PR, try removing this call completely.
Looking at what framework/src/main/java/org/checkerframework/framework/type/TypeFromExpressionVisitor.java method
visitMethodInvocation
does now, I think this can always be removed.I still find it ugly that the TypeFromExpressionVisitor does the capturing and asUse, which logically I would expect to happen in
methodFromUse
.Please file an issue that we clean this up further. In this PR, try removing this call completely.
Originally posted by @wmdietl in #1083 (comment)
The text was updated successfully, but these errors were encountered: