Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relation between ATF methodFromUse/constructorFromUse and TypeFromExpressionVisitor #1088

Open
wmdietl opened this issue Feb 4, 2025 · 0 comments

Comments

@wmdietl
Copy link
Member

wmdietl commented Feb 4, 2025

          This was added in https://github.com/eisop/checker-framework/commit/b420748ca3299785218f657cad76fa9963b78a30

Looking at what framework/src/main/java/org/checkerframework/framework/type/TypeFromExpressionVisitor.java method visitMethodInvocation does now, I think this can always be removed.

I still find it ugly that the TypeFromExpressionVisitor does the capturing and asUse, which logically I would expect to happen in methodFromUse.
Please file an issue that we clean this up further. In this PR, try removing this call completely.

Originally posted by @wmdietl in #1083 (comment)

@wmdietl wmdietl mentioned this issue Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant