Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] When focused window is on second monitor, dock previews are placed in the wrong location #277

Closed
1 task done
bsiegel opened this issue Aug 29, 2024 · 15 comments · Fixed by #254
Closed
1 task done
Labels
bug Something isn't working

Comments

@bsiegel
Copy link

bsiegel commented Aug 29, 2024

Describe the bug

When a window on my secondary monitor has focus, the dock preview seems to think it's in stage manager mode and shows previews vertically along the left edge of the primary monitor. See below.

Steps to reproduce

  • Have two monitors connected
  • Open some windows, and have at least one on the secondary monitor (the monitor without the dock)
  • Click within a window on the secondary monitor to focus it
  • Now hover over an app icon in the dock on the primary monitor

Expected behavior

The dock preview works as expected.

Actual behavior

The dock preview seems to think it's in stage manager mode and shows previews vertically along the left edge of the primary monitor.

Screenshots

Screenshot 2024-08-29 at 2 26 57 PM

Environment

  • macOS version: 14.6.1
  • App version: 1.1.5
  • I have reviewed the open issues to ensure this is not a duplicate
@bsiegel bsiegel added the bug Something isn't working label Aug 29, 2024
@ejbills
Copy link
Owner

ejbills commented Aug 29, 2024

Weird, I will look into this - thanks for the report.

@illavoluntas
Copy link
Contributor

Yes. I don’t think DockDoor thinks it’s Stage Manager mode, but chooses the wrong Dock. What is your configuration?
Left: Secondary; Right: Primary?

@bsiegel
Copy link
Author

bsiegel commented Aug 30, 2024

Yes. I don’t think DockDoor thinks it’s Stage Manager mode, but chooses the wrong Dock. What is your configuration? Left: Secondary; Right: Primary?

Ah yep, that's correct. I have the primary monitor on the right and secondary on the left.

@illavoluntas
Copy link
Contributor

illavoluntas commented Aug 31, 2024

Thanks for confirming, @bsiegel. Ejbills, I think DockDoor chooses the wrong Dock.

@ejbills
Copy link
Owner

ejbills commented Sep 2, 2024

Thanks for confirming, @bsiegel. Ejbills, I think DockDoor chooses the wrong Dock.

The mouse location was failing, leading to it defaulting to .zero (which is the bottom left corner of the main display). This will be fixed in the next release, I have attached the associated PR.

@bsiegel
Copy link
Author

bsiegel commented Sep 4, 2024

@ejbills @illavoluntas This issue is not resolved in 1.2.0, can we re-open the ticket? Or would you prefer I create a new one?

@illavoluntas
Copy link
Contributor

@ejbills @illavoluntas This issue is not resolved in 1.2.0, can we re-open the ticket? Or would you prefer I create a new one?

Did you try 1.2.1? I don’t know if the latter addresses this issue, but you might want to try.

@bsiegel
Copy link
Author

bsiegel commented Sep 4, 2024

@ejbills @illavoluntas This issue is not resolved in 1.2.0, can we re-open the ticket? Or would you prefer I create a new one?

Did you try 1.2.1? I don’t know if the latter addresses this issue, but you might want to try.

Ahh, 1.2.1 was not showing up via autoupdate but I installed it from the GH releases - I can confirm the issue persists in 1.2.1 as well. Sorry for the bad news! And thank you both for your hard work and amazing responsiveness to issues here, this app solves a real problem in an incredible way and for how new it is I'm blown away with the level of quality and polish!

@illavoluntas
Copy link
Contributor

illavoluntas commented Sep 4, 2024

1.2.1 not showing correctly is expected for me because I noticed some files weren't changed correctly for the version bump. Some lines stayed at 1.2.0 and others went for 1.2.1. Well, I hope this error won't be repeated next time!

See 3602a2a (I synced my fork to the repo). Some files are very inconstitent in terms of version number.

@illavoluntas
Copy link
Contributor

@ejbills @illavoluntas This issue is not resolved in 1.2.0, can we re-open the ticket? Or would you prefer I create a new one?

I'll let ejbills decide, I'm not very familiar with GitHub issue conventions. He will be back soon I guess :)

@ejbills
Copy link
Owner

ejbills commented Sep 4, 2024

@bsiegel I was able to reproduce this originally when I looked at the issue. After I pushed the fix, it works properly for me. I am unsure where to go next to try and replicate this issue. I tested on 2 and 3 monitors.

@ejbills ejbills reopened this Sep 5, 2024
@ejbills
Copy link
Owner

ejbills commented Sep 5, 2024

@bsiegel do you have dock hiding enabled? If not, can you toggle it on and see if the issue persists? If so, turn it off and try again?

@ejbills
Copy link
Owner

ejbills commented Sep 5, 2024

I would also like to know your monitor dimensions if possible. We have to use some math to get the dock position, it seems you have a high resolution monitor and a tiny dock, which may be revealing some issues with the math. If you enlarge the dock, does the issue go away?

@bsiegel
Copy link
Author

bsiegel commented Sep 10, 2024

Sorry for the delay - following up with answers to your questions.

I don't have dock hiding enabled. When I turn it on, the issue is resolved - so it appears to only occur when dock hiding is disabled. After turning dock hiding back off, the issue reproduces again.

My dock tilesize is 36. I tried increasing it to 48 and 64, but the issue persists regardless of the size.

$ defaults read com.apple.dock tilesize
36

I have 2x identical 2560x1440 (Lenovo L24q-20) monitors, set side-by-side. My main display is the monitor on the right.
image

@ejbills
Copy link
Owner

ejbills commented Sep 13, 2024

Fixed @bsiegel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants