-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] When focused window is on second monitor, dock previews are placed in the wrong location #277
Comments
Weird, I will look into this - thanks for the report. |
Yes. I don’t think DockDoor thinks it’s Stage Manager mode, but chooses the wrong Dock. What is your configuration? |
Ah yep, that's correct. I have the primary monitor on the right and secondary on the left. |
Thanks for confirming, @bsiegel. Ejbills, I think DockDoor chooses the wrong Dock. |
The mouse location was failing, leading to it defaulting to .zero (which is the bottom left corner of the main display). This will be fixed in the next release, I have attached the associated PR. |
@ejbills @illavoluntas This issue is not resolved in 1.2.0, can we re-open the ticket? Or would you prefer I create a new one? |
Did you try 1.2.1? I don’t know if the latter addresses this issue, but you might want to try. |
Ahh, 1.2.1 was not showing up via autoupdate but I installed it from the GH releases - I can confirm the issue persists in 1.2.1 as well. Sorry for the bad news! And thank you both for your hard work and amazing responsiveness to issues here, this app solves a real problem in an incredible way and for how new it is I'm blown away with the level of quality and polish! |
1.2.1 not showing correctly is expected for me because I noticed some files weren't changed correctly for the version bump. Some lines stayed at 1.2.0 and others went for 1.2.1. Well, I hope this error won't be repeated next time! See 3602a2a (I synced my fork to the repo). Some files are very inconstitent in terms of version number. |
I'll let ejbills decide, I'm not very familiar with GitHub issue conventions. He will be back soon I guess :) |
@bsiegel I was able to reproduce this originally when I looked at the issue. After I pushed the fix, it works properly for me. I am unsure where to go next to try and replicate this issue. I tested on 2 and 3 monitors. |
@bsiegel do you have dock hiding enabled? If not, can you toggle it on and see if the issue persists? If so, turn it off and try again? |
I would also like to know your monitor dimensions if possible. We have to use some math to get the dock position, it seems you have a high resolution monitor and a tiny dock, which may be revealing some issues with the math. If you enlarge the dock, does the issue go away? |
Fixed @bsiegel |
Describe the bug
When a window on my secondary monitor has focus, the dock preview seems to think it's in stage manager mode and shows previews vertically along the left edge of the primary monitor. See below.
Steps to reproduce
Expected behavior
The dock preview works as expected.
Actual behavior
The dock preview seems to think it's in stage manager mode and shows previews vertically along the left edge of the primary monitor.
Screenshots
Environment
The text was updated successfully, but these errors were encountered: