Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: release notes loading #148

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fix: release notes loading #148

merged 1 commit into from
Jul 11, 2024

Conversation

ShlomoCode
Copy link
Contributor

@ShlomoCode ShlomoCode commented Jul 11, 2024

CleanShot 2024-07-11 at 05 22 30@2x

I think this is because of the change from releaseNotesLink to fullReleaseNotesLink

https://sparkle-project.org/documentation/publishing/#:~:text=Sparkle%20may%20let%20the%20user%20open%20this%20link%20in%20their%20web%20browser We want Sparkle to display the report in its built-in browser, not send a link to the browser.

@ejbills ejbills merged commit dd5d0d8 into ejbills:main Jul 11, 2024
2 checks passed
@ShlomoCode ShlomoCode deleted the patch-2 branch July 11, 2024 02:34
@ShlomoCode
Copy link
Contributor Author

🎉
CleanShot 2024-07-11 at 05 34 44@2x

@ShlomoCode
Copy link
Contributor Author

@ejbills commit 67e3b0b reverted this fix, and the update window is sad again:
CleanShot 2024-07-16 at 04 25 37@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants