Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing of_yojson for FlecheDocument module #862

Open
blackbird1128 opened this issue Oct 17, 2024 · 1 comment
Open

Missing of_yojson for FlecheDocument module #862

blackbird1128 opened this issue Oct 17, 2024 · 1 comment
Labels
kind: bug Something isn't working part: lsp server
Milestone

Comments

@blackbird1128
Copy link

Describe the bug

There is no of_yojson function for the FlecheDocument module

To Reproduce

Steps to reproduce the behavior:

  1. Get a JSON representation of the FlecheDocument using coq/getDocument
  2. There is no function to convert to a FlecheDocument from the JSON.

Expected behavior

An implementation of of_yojson for this module.

Desktop

  • Operating system: Ubuntu
  • coq-lsp version: 0.1.8
  • VS Code version: Not used here

Additional context

See https://coq.zulipchat.com/#narrow/channel/329642-coq-lsp/topic/coq-lsp.20and.20ocaml for more details

@blackbird1128 blackbird1128 added the kind: bug Something isn't working label Oct 17, 2024
@ejgallego ejgallego added this to the 0.2.3 milestone Oct 21, 2024
@ejgallego
Copy link
Owner

Thanks for the bug report.

To shed some light on this issue, this is mostly due to the way we handle Range in Flèche.

Flèche uses a range type that also includes offsets, which means we have a harder time de-serializing stuff that comes from the client without and offset.

I will try to open a discussion LSP upstream, meanwhile I will provide a workaround locally.

@ejgallego ejgallego modified the milestones: 0.2.3, 0.2.4 Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working part: lsp server
Projects
None yet
Development

No branches or pull requests

2 participants