Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GZipping files #228

Closed
elmarti opened this issue Aug 15, 2019 · 4 comments · Fixed by #230
Closed

GZipping files #228

elmarti opened this issue Aug 15, 2019 · 4 comments · Fixed by #230

Comments

@elmarti
Copy link

elmarti commented Aug 15, 2019

The documented method for GZipping files breaks my TS compiler and doesn't appear to work when looking at the code. Has this been replaced with toGzip()? I may PR with a documentation update in a few days, but i'm still getting to grips with the package.

@elmarti
Copy link
Author

elmarti commented Aug 15, 2019

Right, i appear to have misread the documentation, there is a gzip option on the createSitemapIndex documentation, which works perfectly, the point still stands about the lack of documentation, happy to create a PR unless i've missed something?

@derduher
Copy link
Collaborator

PR welcome. I've just done a docs overhaul so I probably missed it.

@derduher
Copy link
Collaborator

Also feel free to drop any suggestions for improvement in here.

@derduher
Copy link
Collaborator

@elmarti I've added some docs but still feel free to open a PR for improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants