-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Official docker image #1121
Comments
To complete the picture, this is a reference to the process we do per each release. |
@eyalkoren Hah! I'm actually really happy when we can be of service to teams! Thanks for alerting me to this. @bmorelli25 We should definitely talk about this. There may be a lot of what we did for the Java folks that we could re-use for you. |
++ this will be useful for #1073, to test the startup hook |
As there's a good workaround in place (downloading the agent binaries via wget in an init container), I'd say that the priority for this is not critical. Especially, because the longer-term direction is to rely on the agent binaries bundled with APM Server rather than Docker images containing the agent binaries for k8s. See also elastic/apm#383 But if we get to it, it would be nice to completely automate the step of publishing the Docker image. We manually publish Docker images for the Java agent for quite a while now which makes the release process more painful. So if we want to extend the Docker image publishing to other agents such as .NET and Node.js, I think automating that step during the release is a requirement. |
This has been implemented apm-agent-dotnet/build/scripts/Build.fs Lines 241 to 250 in bab7761
which can be built with
(use .bat on Windows and .sh on non-Windows) so a docker image with startup hooks can be built, but we don't artifact it. I'm going to close this issue out for now, and if an ask comes up for publishing the image, we can handle it in a new issue. |
Overview
An official docker image for the APM .NET agent would simplify the use of the agent in a Kubernetes environment. Per @eyalkoren:
For now, we do have a workaround documented.
Related
The Java agent already publishes an official docker image. Their implementation issue offers a ton of additional information: elastic/apm-agent-java#997
The text was updated successfully, but these errors were encountered: