Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture request body in ASP.NET Core #213

Closed
gregkalapos opened this issue Apr 25, 2019 · 4 comments · Fixed by #402
Closed

Capture request body in ASP.NET Core #213

gregkalapos opened this issue Apr 25, 2019 · 4 comments · Fixed by #402
Labels
cross APM agents .NET Core

Comments

@gregkalapos
Copy link
Contributor

gregkalapos commented Apr 25, 2019 •
edited by alvarolobato
Loading

Trigger by this comment.

In #134 we added the Request.Body field, but that is only utilized by API tests, so the only way to use it is to manually set the request body.

Other agents have a setting for this. E.g. see here.

We should add this config setting and extend our ASP.NET Core instrumentation to behave accordingly.
@gregkalapos gregkalapos mentioned this issue Apr 25, 2019
Closed
@SergeyKleyman
Copy link
Contributor

@gregkalapos Should we open a separate issue for .NET Framework?

@gregkalapos
Copy link
Contributor Author

@gregkalapos Should we open a separate issue for .NET Framework?

Yeah, we can do that. I don't see it super important at this point though.

@SergeyKleyman SergeyKleyman mentioned this issue Jul 17, 2019
Closed
@katzdan
Copy link
Contributor

katzdan commented Jul 17, 2019

I'll start working on this and report here.

@katzdan katzdan mentioned this issue Aug 13, 2019
Merged
@SergeyKleyman SergeyKleyman mentioned this issue Aug 13, 2019
Closed
@gregkalapos
Copy link
Contributor Author

Implemented by @katzdan in #402

@zube zube bot removed the [zube]: Done label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cross APM agents .NET Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Capture request body aspnet core katzdan/apm-agent-dotnet
4 participants
@gregkalapos @katzdan @SergeyKleyman @alvarolobato