Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Custom fields #419

Closed
skynet2 opened this issue Jul 30, 2019 · 7 comments
Closed

Add support for Custom fields #419

skynet2 opened this issue Jul 30, 2019 · 7 comments
Assignees
Labels
cross APM agents enhancement New feature or request

Comments

@skynet2
Copy link
Contributor

skynet2 commented Jul 30, 2019

Can not reopen original issue #116

Per last conversation on APM discussion elastic/apm#7 it was decided to stay with custom.
It will good to have that in APM agent.

Thanks,
Stas

@skynet2 skynet2 added the enhancement New feature or request label Jul 30, 2019
@SergeyKleyman
Copy link
Contributor

@skynet2 Could you please give an example as to why you would like to use custom part of the context and not labels?

@SergeyKleyman
Copy link
Contributor

@skynet2 I see that you already gave an example at #118 (comment)

the reason why i decided to use custom is that it can save big objects, for example, requests and response.

@SergeyKleyman
Copy link
Contributor

BTW I see that Java agent 1.7.0 added support for custom context. Other agents support custom context as well:

@axw Does Go agent support custom context?

@skynet2
Copy link
Contributor Author

skynet2 commented Jul 31, 2019

Hi @SergeyKleyman ,
Yep, go agent has support for that elastic/apm-agent-go#594 (comment)

@alexandre-sampaio
Copy link

Hi! is anyone working on it?
I need this to save the body from response, maybe there is another way, but i didn't find it.

@skynet2
Copy link
Contributor Author

skynet2 commented Oct 16, 2019

@alexandre-sampaio for as a temporary solution use Request.Body. According to APM specification it can be both, string or object., so for me its simple key-value pairs.

@gregkalapos
Copy link
Contributor

Implemented in #585 - will be included in the next minor release.

@gregkalapos gregkalapos self-assigned this Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cross APM agents enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants