Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Context.SetCustom #282

Closed
axw opened this issue Oct 26, 2018 · 1 comment
Closed

Remove Context.SetCustom #282

axw opened this issue Oct 26, 2018 · 1 comment

Comments

@axw
Copy link
Member

axw commented Oct 26, 2018

It's not clear whether it's useful to have both Context.SetCustom/SetTag, so we'll remove Context.SetCustom for now until it's clear that we need it. It will be much harder to remove it later if we decide it's unnecessary.
@axw
Copy link
Member Author

axw commented Oct 26, 2018

See elastic/apm#7

@axw axw mentioned this issue Oct 26, 2018
Merged
@axw axw closed this as completed Oct 29, 2018
@axw axw removed the [zube]: Done label Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@axw