Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing context.message.topic field #982

Closed
3 of 4 tasks
eyalkoren opened this issue Jan 6, 2020 · 2 comments · Fixed by #993
Closed
3 of 4 tasks

Removing context.message.topic field #982

eyalkoren opened this issue Jan 6, 2020 · 2 comments · Fixed by #993
Milestone

Comments

@eyalkoren
Copy link
Contributor

eyalkoren commented Jan 6, 2020

Based on the update in elastic/apm#143, there is no context.message.topic anymore.
Required in:

  • JMS
  • Kafka
  • Context serialization
  • Do we want to remove JMS from its incubating state?
@eyalkoren eyalkoren added this to the 7.6 milestone Jan 6, 2020
@videnkz
Copy link
Contributor

videnkz commented Jan 14, 2020

Hi @eyalkoren , should we remove "topic" from span name?

@eyalkoren
Copy link
Contributor Author

Hi @kananindzya 🙂 !
You mean for JMS? I think not- JMS uses queues and topics for different purposes, so it makes sense that the name of the spans will indicate that. This issue is about removing the context.message.topic.name field and using only context.message.queue.name, because it will always either be one or the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants