Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

express-graphql >=0.10.0 instrumentation with node <10.4 doesn't work #2516

Open
trentm opened this issue Dec 10, 2021 · 0 comments
Open

express-graphql >=0.10.0 instrumentation with node <10.4 doesn't work #2516

trentm opened this issue Dec 10, 2021 · 0 comments
Labels
agent-nodejs Make available for APM Agents project planning. bug

Comments

@trentm
Copy link
Member

trentm commented Dec 10, 2021

The work in #2511 to add support for more recent versions of express-graphql hit an issue: There is some issue with express-graphql >=0.10.0 and node <10.4 (released 2018-06-06) such that the wrapped graphql.execute called by express-graphql is not in the run context of the transaction, so the graphql span does not get created and the transaction does not get marked as a GraphQL transaction.

It works with [email protected], FWIW. I'm not sure what is going on; but I'm also not sure it is worth supporting given node v10 is EOL at this point.

@trentm trentm added the bug label Dec 10, 2021
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning. bug
Projects
None yet
Development

No branches or pull requests

1 participant