Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate the use of Object Fields (JSONF) #1477

Closed
alvarolobato opened this issue Oct 25, 2018 · 7 comments
Closed

Investigate the use of Object Fields (JSONF) #1477

alvarolobato opened this issue Oct 25, 2018 · 7 comments
Assignees
Milestone

Comments

@alvarolobato
Copy link

alvarolobato commented Oct 25, 2018

Investigate and potentially implement an APM Server mapping change of Custom field: Object Field -
JSONF

@roncohen
Copy link
Contributor

This is the related elasticsearch issue: elastic/elasticsearch#33003

@alvarolobato alvarolobato changed the title Investigate JSONF Investigate the use of Object Fields (JSONF) Oct 25, 2018
@alvarolobato alvarolobato added this to the 6.6 milestone Nov 13, 2018
@roncohen
Copy link
Contributor

roncohen commented Dec 3, 2018

This comment elastic/elasticsearch#25312 (comment) has some implication for our use case:

  • Kuery bar will not be able to show type ahead for tags
  • Users will be able to filter, but never aggregate using tags. E.g. you cannot do show me TOP 10 context.tags.org_uuid

@simitt
Copy link
Contributor

simitt commented Dec 21, 2018

Current use cases with dynamic user input:

  • context.tags: As @roncohen pointed out, there would be some drawbacks. The most crucial one would be that it doesn't allow term aggregations.
  • transaction.marks: Allows dynamic and user defined input, mostly related to numbers though, in which case JSONF would not be a good solution, as it is aiming for text support atm.
  • context.custom: currently only stored, not indexed. For custom json blobs this could be a valid use case as it gives more flexibility to customers. There are ongoing discussions though to completely remove support for context.custom.

After reading up on JSONF I don't think that we have any use cases for it at the moment, so I suggest to close this issue, but keep an eye on the feature for potential future use cases.

@jalvz
Copy link
Contributor

jalvz commented Jan 9, 2019

Agreed, vote for close too

@simitt
Copy link
Contributor

simitt commented Jan 9, 2019

@roncohen if there are no objections I'll close this.

@simitt
Copy link
Contributor

simitt commented Jan 21, 2019

@roncohen any feedback on this - are you good with closing?

@roncohen
Copy link
Contributor

OK. Let's close it. It's too bad because this would fix the field explosions problem elegantly and @jtibshirani opened up for the possibility that it might support aggregations some time. However, since we did numbers support on tags (#1712) instead, we'll be unable to benefit from this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants