-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM: Add longtask to experience field on transaction schema #4226
Comments
@jahtalab thanks for adding the rationale. What is the duration measured in? Ideally it would be milliseconds, to align with transaction and span duration fields. Ideally we would record these all in an
Apart from lack of "max", can you please also explain why we can't use breakdown metrics for this? AIUI, we don't capture breakdown metrics for page-load transactions. Why not? Can we do that instead? Do we need long task metrics for individual transactions, or only at an aggregated level?
Unshortened is fine.
We should be able to get this into 7.10. |
@jahtalab the RUM V3 endpoint already supports a couple of user experience values, sent via the shortened |
@simitt Copying the feedback posted on the original PR, We would like to hear server team's thoughts before doing the shortening on the fields. I am +1 on shortening the fields from RUM level to ensure consistency even though savings are not huge as Hamid mentioned.
|
@simitt , It's only for the longtask field the other ones stay the same. The main reason for not shortening these is that the impact of doing so, i.e. payload size benefit is not significant. Specially since there's a compression API in browsers that RUM agent supports already. Although not all browsers support this new API, chromium based browser do (that's already a big part of the market) and as browsers catch up the benefit of shortening fields diminishes. I think we should keep shortening for current fields specially for spans (since they outnumber transactions by a large ratio), but for new fields on transactions we should avoid it. |
I don't have an opinion on shortening or not - was just wondering since the v3 Intake API was built with all well defined fields being shortened - IMO up to @jahtalab and @vigneshshanmugam to decide on this. |
@vigneshshanmugam |
@vigneshshanmugam and I discussed it, going forward we will shorten fields that are overly long but for fields like @axw , we can't use the breakdown metrics for this since we currently can't generate breakdowns for page-load transactions, the reason is that we can't determine correct breakdowns based on page-load spans. We currently only send breakdowns for network events. |
I assume you mean that we can't generate correct network breakdown for page-load transactions? Breakdown metrics are just a convention really. You can create any metrics you like, and associate them with a transaction name/type. For page-load you could just emit breakdown metrics for longtasks, and not network. Anyway, since breakdown metrics don't currently include "max", and it could be useful to have this information at the individual transaction level anyway, let's move ahead with the proposal. |
That's correct @axw , another reason we can't use the metrics is that on the dashboard we need to be able to filter by url (and other attributes on the transaction) and doing a multi-step query is too expensive. In fact we were trying to do this via spans but that had the same issue with the query. |
In order to make querying longtasks easier we need to add aggregation over longtasks to transactions. The RUM agent provides this aggregation under the experience field as follows:
Shortened form:
Note: longtask is optional and might not be present in the payload.
@axw , would you please provide a timeline for this change?
The text was updated successfully, but these errors were encountered: