Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies on filebeat modules configuration load #11943

Closed
jsoriano opened this issue Apr 26, 2019 · 4 comments
Closed

Inconsistencies on filebeat modules configuration load #11943

jsoriano opened this issue Apr 26, 2019 · 4 comments
Labels
bug Filebeat Filebeat module Stalled Team:Integrations Label for the Integrations team

Comments

@jsoriano
Copy link
Member

Filebeat modules configuration load has some inconsistencies with other beats, and between different ways of configuring it. These differences make filebeat modules configuration to be error prone with some custom configurations, or when moving from one configuration method to other.

  • It is not possible to configure the same module several times in the main file (under filebeat.modules).
    • If the same module is defined several times in filebeat.modules, only the last configuration seen is applied.
    • It is possible to configure the same modules several times with autodiscover, or using filebeat.config.modules. With filebeat.config.modules it works both when the definitions are in different files or in the same one.
  • Not used filesets have to be explicitly disabled if the module is used. This happens with all configuration methods in filebeat but it doesn't happen in other beats, where only the listed datasets are enabled.

We might need to refactor filebeat modules configuration in order to address these inconsistencies.

@jsoriano jsoriano added bug module discuss Issue needs further discussion. Filebeat Filebeat labels Apr 26, 2019
@jsoriano
Copy link
Member Author

It is not possible to configure the same module several times in the main file (under filebeat.modules).

To fix this we could have in filebeat.modules the same behaviour we have when defining multiple modules in a single file included from filebeat.config.modules.path.

Not used filesets have to be explicitly disabled if the module is used. This happens with all configuration methods in filebeat but it doesn't happen in other beats, where only the listed datasets are enabled.

An option to implement this in a backwards-compatible way could be to add a filesets option to filebeat modules, if not set it keeps current behaviour of loading all filesets, if it is set it only loads the listed filesets.

@jsoriano jsoriano added the Team:Integrations Label for the Integrations team label Oct 15, 2019
@andresrc andresrc added [zube]: Inbox [zube]: Investigate and removed discuss Issue needs further discussion. [zube]: Inbox labels Oct 29, 2019
@jsoriano jsoriano removed their assignment Jun 10, 2020
@jsoriano
Copy link
Member Author

* Not used filesets have to be explicitly disabled if the module is used. This happens with all configuration methods in filebeat but it doesn't happen in other beats, where only the listed datasets are enabled.

Solution proposed in #17256.

@botelastic
Copy link

botelastic bot commented Jan 23, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the Stalled label Jan 23, 2022
@faec
Copy link
Contributor

faec commented Apr 4, 2022

Looks like this was resolved by @adriansr in #27526.

@faec faec closed this as completed Apr 4, 2022
@zube zube bot removed the [zube]: Done label Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Filebeat Filebeat module Stalled Team:Integrations Label for the Integrations team
Projects
None yet
Development

No branches or pull requests

3 participants