Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add username/password in Metricbeat autodiscover hints #15115

Closed
ChrsMark opened this issue Dec 16, 2019 · 2 comments · Fixed by #15349
Closed

Add username/password in Metricbeat autodiscover hints #15115

ChrsMark opened this issue Dec 16, 2019 · 2 comments · Fixed by #15349
Assignees
Labels
autodiscovery enhancement Team:Integrations Label for the Integrations team test-plan Add this PR to be manual test plan

Comments

@ChrsMark
Copy link
Member

ChrsMark commented Dec 16, 2019

Describe the enhancement:
Currently we don't have username/password in autodiscover hints. In order to set this you need to make use of raw hint. Since these are really common configuration options we should consider adding them to the list of known hints.

Describe a specific use case for the enhancement or feature:
https://discuss.elastic.co/t/metricbeat-autodiscover-hints-for-mysql/211575/3

Implementation would be similar to #14208.

Manual Testing

  1. Enable autodiscover in metricbeat.yml
metricbeat:
  autodiscover.providers:
    - type: docker
      hints.enabled: true
  1. Start metricbeat with log enabled: ./metricbeat -e -d "hints.builder"
  2. docker run -l co.elastic.metrics/module=nats -l co.elastic.metrics/username=user42 --name nats nats
  3. Check in Metricbeat logs for : 2019-12-16T15:53:18.712+0200 DEBUG [hints.builder] hints/metrics.go:144 generated config: {"enabled":true,"hosts":null,"metricsets":["connections","routes","stats","subscriptions"],"module":"nats","period":"1m","processors":null,"ssl":null,"timeout":"3s","username":"user42"}
@rvillablanca
Copy link
Contributor

This issue is marked as good first issue but it already has a PR in progress. Is there any label to mark some issues that have PR ?

@ChrsMark ChrsMark added [zube]: In Progress in progress Pull request is currently in progress. and removed good first issue Indicates a good issue for first-time contributors labels Jan 9, 2020
@ChrsMark
Copy link
Member Author

ChrsMark commented Jan 9, 2020

This issue is marked as good first issue but it already has a PR in progress. Is there any label to mark some issues that have PR ?

Hey usually they should be marked with in progress label. I just added it.

@ChrsMark ChrsMark added the test-plan Add this PR to be manual test plan label Jan 9, 2020
@ChrsMark ChrsMark removed the in progress Pull request is currently in progress. label Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autodiscovery enhancement Team:Integrations Label for the Integrations team test-plan Add this PR to be manual test plan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants