Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic-Agent] Allow to specify what artifacts to embed at build times #19623

Closed
ph opened this issue Jul 2, 2020 · 3 comments
Closed

[Elastic-Agent] Allow to specify what artifacts to embed at build times #19623

ph opened this issue Jul 2, 2020 · 3 comments
Assignees

Comments

@ph
Copy link
Contributor

ph commented Jul 2, 2020

We need to embed signatures files at build times to allow us to verify the artifacts in the work in #19222. The Elastic Agent is built by the release manager which also builds all the other artifacts.

We need to change the order of operation.

  • build filebeat/create signature.
  • build metricbeat/create signature file
  • build endpoint/create signature file.
  • build Elastic-Agent with the right "archives" and the right signature files.

To do this we could have at parameters at build times to specify what needs to be embedded.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@Conky5
Copy link

Conky5 commented Jul 9, 2020

To be clear the order of operations today looks like:

  1. All beats projects are built
  2. release-manager generates signature files
  3. downstream codesigning jobs are run
  4. release-manager re-generates signature files for codesigned artifacts

What I think we'll want it to look like:

  1. All beats projects minus elastic-agent are built
  2. release-manager generates signature files
  3. downstream codesigning jobs are run
  4. release-manager re-generates signature files for codesigned artifacts
  5. The elastic-agent build runs, which is passed the fully signed artifacts and signature files by release-manager, which are then bundled into the elastic-agent distribution
  6. release-manager generates signature files for the elastic-agent archives

@michalpristas
Copy link
Contributor

this one's already in place, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants