Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodiscover could reach to k8s client's default rate limit #28149

Closed
newly12 opened this issue Sep 28, 2021 · 2 comments · Fixed by #28151
Closed

Autodiscover could reach to k8s client's default rate limit #28149

newly12 opened this issue Sep 28, 2021 · 2 comments · Fixed by #28151
Labels
enhancement Team:Integrations Label for the Integrations team

Comments

@newly12
Copy link
Contributor

newly12 commented Sep 28, 2021

Describe the enhancement:
currently when using autodiscover for pod resources, beats adds deployment.name if the specific pod owned by ReplicaSet that's also owned by Deployment, in this function getRSDeployment, go client was used directly without leveraging k8s cache/store, however go client has QPS 5 and Burst 10 by default, which could be a bottle neck of autodiscover. It may not be a good idea to introduce a replicaset watcher because of memory overhead, which seems the only way to accelerate this function is adding options to configure the client's QPS/Burst.

Describe a specific use case for the enhancement or feature:
in k8s clusters that a single beats' pod is responsible for a lot of pods.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 28, 2021
@andresrc andresrc added enhancement Team:Integrations Label for the Integrations team labels Oct 14, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 14, 2021
@ChrsMark
Copy link
Member

cc: @akshay-saraswat @mukeshelastic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants