Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use named watcher for elastic agent kubernetes composable provider #28780

Closed
MichaelKatsoulis opened this issue Nov 3, 2021 · 1 comment · Fixed by #29095
Closed

Use named watcher for elastic agent kubernetes composable provider #28780

MichaelKatsoulis opened this issue Nov 3, 2021 · 1 comment · Fixed by #29095
Assignees
@ChrsMark
Labels
Team:Integrations Label for the Integrations team

Comments

@MichaelKatsoulis
Copy link
Contributor

After merging of #28085 which introduces the named watcher (a name is passed into the kubernetes watcher which is then given to the work queue), elastic agent composable kubernetes provider should also be updated to leverage this functionality.

Maybe we can consider completely replacing NewWatcher function and use NewNamedWatcher in its place.
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 3, 2021
@MichaelKatsoulis MichaelKatsoulis added the Team:Integrations Label for the Integrations team label Nov 3, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 3, 2021
@ChrsMark ChrsMark self-assigned this Nov 23, 2021
@ChrsMark ChrsMark mentioned this issue Nov 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrsMark ChrsMark

Labels
Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use NamedWatcher in Agent's k8s provider ChrsMark/beats
3 participants
@ChrsMark @elasticmachine @MichaelKatsoulis