Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the add_cloud_metadata processor enrich events with EC2 tags #31899

Closed
psypuff opened this issue Jun 9, 2022 · 10 comments · Fixed by #41477
Closed

Have the add_cloud_metadata processor enrich events with EC2 tags #31899

psypuff opened this issue Jun 9, 2022 · 10 comments · Fixed by #41477
Assignees
Labels
enhancement Team:Cloud-Monitoring Label for the Cloud Monitoring team

Comments

@psypuff
Copy link

psypuff commented Jun 9, 2022

Describe the enhancement:
Similar to #12263 but not for a specific module, for anything beats is monitoring within an EC2 VM.
Since Jan 2022 EC2 tags are also available through the Instance Metadata Service. This is where the add_cloud_metadata processor fetches metadata from anyway so it doesn't seem like a big change.

Describe a specific use case for the enhancement or feature:
This will allow filtering and grouping hosts based on EC2 tags (e.g. Name) in the Observability metrics inventory view of Kibana (and probably some other views as well). This is much more useable than IPs or instance IDs.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 9, 2022
@belimawr belimawr added enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Jun 16, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 16, 2022
@botelastic
Copy link

botelastic bot commented Jun 16, 2023

Hi!
We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jun 16, 2023
@cmacknz cmacknz added Team:Cloud-Monitoring Label for the Cloud Monitoring team and removed Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Jun 16, 2023
@botelastic botelastic bot removed the Stalled label Jun 16, 2023
@hatdropper1977
Copy link

@cmacknz - Can we get this feature enabled?

@cmacknz
Copy link
Member

cmacknz commented Jul 27, 2023

@bturquet would know if this is planned for the near future.

@bturquet
Copy link

Added it in Triage stage for further prioritization, will let you know when we'll have an ETA

@markjandejong
Copy link

@bturquet Any word on this feature? This would be extremely useful!

@bturquet
Copy link

bturquet commented May 6, 2024

@dejongm this issue has been added to an internal META issue for the add_cloud_metadata processor, but it is not part of any iteration yet. We may start working on it for may or june iteration only, will share more details when I'll know more, thank you.

@george-viaud
Copy link

This feature would be very useful for our org. Presently we need to modify logs to include this data individually. Having it provided natively would reduce a lot off pain at the instance level. Thank you

@itay-ct
Copy link

itay-ct commented Aug 5, 2024

+1

@Kavindu-Dodan
Copy link
Contributor

Kavindu-Dodan commented Oct 25, 2024

IMDS [1] only exposes tags if instance explicitly expose them in metadata ,

The instance tags associated with the instance. Only available if you explicitly allow access to tags in instance metadata. [2]

Enabling tags can be done through the console or CLI [3].


Update - 1

Along with the improvement, we could improve how we derive eks:cluster-name [4]. However, I will still provide a fallback as tag exposure is optional as previously mentioned.

[1] - https://github.com/elastic/beats/blob/main/libbeat/processors/add_cloud_metadata/provider_aws_ec2.go#L127

[1] - https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-instance-metadata.html
[2] - https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-instance-metadata.html#instancedata-data-categories
[3] - https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/work-with-tags-in-IMDS.html
[4] - https://github.com/elastic/beats/blob/v8.15.3/libbeat/processors/add_cloud_metadata/provider_aws_ec2.go#L127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants