Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] beat module - add metricset for input metrics #33953

Closed
andrewkroh opened this issue Dec 6, 2022 · 6 comments
Closed

[Metricbeat] beat module - add metricset for input metrics #33953

andrewkroh opened this issue Dec 6, 2022 · 6 comments
Assignees
Labels
enhancement Metricbeat Metricbeat Module:beat The beat Metricbeat module needs_team Indicates that the issue/PR needs a Team:* label

Comments

@andrewkroh
Copy link
Member

Describe the enhancement:

Add a new input metricset to the Beat module to collect metrics from various inputs with Beats (e.g. aws-s3, winlog, udp). Several of the inputs already export per instance metrics and we are exposing those metrics under /inputs/ on the Beat http monitoring endpoint.

Describe a specific use case for the enhancement or feature:

Once we can collect these metrics we can build dashboards to help understand and diagnose issues with input behavior or configuration. For example this metricset could be enabled as part of Agent monitoring to collect input metrics from Filebeat. Then dashboards could be created in the elastic_agent Fleet integration package for each input type to make sense of the data.

Relates

@andrewkroh andrewkroh added enhancement Metricbeat Metricbeat Module:beat The beat Metricbeat module labels Dec 6, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 6, 2022
@belimawr belimawr added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Dec 12, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 12, 2022
@belimawr belimawr removed the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Dec 12, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 12, 2022
@botelastic
Copy link

botelastic bot commented Dec 12, 2022

This issue doesn't have a Team:<team> label.

@andrewkroh
Copy link
Member Author

andrewkroh commented Jan 4, 2023

On this we are going to pivot to using the http.json metricset with Metricbeat rather than adding new code in the Beat module. This should work given that /inputs/ is returning an array.

So let's build up a Metricbeat configuration and test it standalone. Then we'll prepare to add it into Agent 1 to monitor Filebeat.

  • Agent should only run this when monitoring Filebeat since it's the only Beat with /inputs/ at the current time.
  • Add mappings for this data to the metrics-elastic_agent.filebeat data stream.

Footnotes

  1. https://github.com/elastic/elastic-agent/blob/ab2cf8a6caea84f48a43e8d61fd4a5ff6aa221bc/internal/pkg/agent/application/monitoring/v1_monitor.go#L514

@kcreddy
Copy link
Contributor

kcreddy commented Jan 5, 2023

Thanks for the updates. I will get started and test it standalone

@kcreddy
Copy link
Contributor

kcreddy commented Jan 5, 2023

CC: @epixa

@andrewkroh
Copy link
Member Author

This was implemented via the http.json metricset in Metricbeat. There was no need to add a new metricset to implement this. See elastic/integrations#5077 and elastic/elastic-agent#2171.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Metricbeat Metricbeat Module:beat The beat Metricbeat module needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants