Beats shipper output will not enable TLS

[fearful-symmetry]

Right now, the shipper output will use a simple if block to determine if it should use TLS or not:

	if s.config.TLS != nil && s.config.TLS.Enabled != nil && *s.config.TLS.Enabled {
		creds = credentials.NewTLS(tls.ToConfig())
		s.log.Debugf("beat is running with TLS")
	} else {
		creds = insecure.NewCredentials()
		s.log.Debugf("beat is running with insecure gRPC credentials")
	}

Problem is, right now, elastic-agent will never send an enabled: true field in the TLS setting, presumably as elastic-agent assumes we'll always be operating under TLS. We either need to remove the enabled field, or just set enabled: true in the default setting before we unpack the config.

[elasticmachine]

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

[blakerouse]

That seems agains the standard way we do enabled: true? Normally if a block is defined:

tls: {}

Then enabled: true is implied. Doesn't enabled: false have to be explicit? We should strive for consistency.

[fearful-symmetry]

@blakerouse yah, that would be ideal. I just wasn't 100% sure if elastic-agent was working as desired here.

[pierrehilbert]

@cmacknz / @leehinman could we close this one with the new shipper plan?

[cmacknz]

Still relevant

[jlind23]

The shipper project has been revisited hence closing this as outdated/not relevant.