Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Lightweight monitors - Monitors with malformed params do not produce a summary document with error #34926

Closed
dominiqueclarke opened this issue Mar 24, 2023 · 3 comments
Labels
bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.8.0

Comments

@dominiqueclarke
Copy link

dominiqueclarke commented Mar 24, 2023

  • Version: 8.8.0

I'm currently testing lightweight params using the dev service environment.

While the feature is generally working well, I encountered some uncaught parsing errors. These errors will typically cause the param to be passed to the configuration value raw. For example

check.request.headers : { Authorization: 'Basic ${es_token}' }

While those errors have been addressed by making the Kibana code even more defense, I've noticed that when parameters are passed to heartbeat this way, the monitor does not run at all or report any errors.

It would be helpful for heartbeat to produce a summary document with an error to provide debugging context to our users.

@dominiqueclarke dominiqueclarke added Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.8.0 labels Mar 24, 2023
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@dominiqueclarke
Copy link
Author

After continuing to test lightweight monitor params in Kibana, monitor params will also be returned raw when the param is not defined, not just on unhandled exceptions.

check.request.headers : { Authorization: 'Basic ${a_param_that_is_not_defined}' }

@emilioalvap
Copy link
Collaborator

Closing without action, not reproducible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.8.0
Projects
None yet
Development

No branches or pull requests

4 participants