Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make generators to use govendor #3900

Closed
vjsamuel opened this issue Apr 3, 2017 · 5 comments
Closed

Make generators to use govendor #3900

vjsamuel opened this issue Apr 3, 2017 · 5 comments
Labels
enhancement :Generator Related to code generators for building custom Beats or modules. needs_team Indicates that the issue/PR needs a Team:* label Stalled

Comments

@vjsamuel
Copy link
Contributor

vjsamuel commented Apr 3, 2017

On creating my own beat using python .../beats/script/generate.py --type=metricbeat and then running make, it creates a glide.yml and creates the vendor directory with the entire vendor directory. I might not need the entire vendor directory. It would be easier to switch over to govendor and do:

govendor init
govendor add +e

@ruflin
Copy link
Contributor

ruflin commented Apr 5, 2017

As glide was rather broken for some time we moved away from recommending any vendor solution. I need to check if the glide.yml file is still in their because that should not be :-(

In general I agree on using govendor for this as it would heavily reduce the size of used packages. One worry I have is that it potentially removes some files which are needed (python scripts and Makefile). Best way to find it out is trying. Did you make the switch to govendor in your repo?

@andrewkroh andrewkroh added :Generator Related to code generators for building custom Beats or modules. enhancement labels Sep 17, 2018
@andrewkroh
Copy link
Member

Similar to #2997.

@jsoriano
Copy link
Member

Not sure if this still applies. But this will surely change with the support of go modules (#15853).

@botelastic
Copy link

botelastic bot commented Jan 17, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added Stalled needs_team Indicates that the issue/PR needs a Team:* label labels Jan 17, 2021
@botelastic
Copy link

botelastic bot commented Jan 17, 2021

This issue doesn't have a Team:<team> label.

@botelastic botelastic bot closed this as completed Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement :Generator Related to code generators for building custom Beats or modules. needs_team Indicates that the issue/PR needs a Team:* label Stalled
Projects
None yet
Development

No branches or pull requests

4 participants