Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] [Elasticsearch] Error in case of missing settings key #42424

Closed
3kt opened this issue Jan 24, 2025 · 1 comment · Fixed by #42426
Closed

[Metricbeat] [Elasticsearch] Error in case of missing settings key #42424

3kt opened this issue Jan 24, 2025 · 1 comment · Fixed by #42426

Comments

@3kt
Copy link
Contributor

3kt commented Jan 24, 2025

With the addition of an extra settings API call in PR in the Metricbeat Elasticsearch module, there is a possible misbehavior if one of the key isn't found (or its path for that matters).

This results in error like the one below:

5 errors: failure adding index settings: failed to get index settings for index .geoip_databases: key not found
[...]

We will want to do multiple things:

  1. Ensure we have test coverage for this, as what should cover this is currently skipped.
  2. Modify the code so that a missing path or leaf doesn't yield an error. As this is an "internal" field, the absence of the field shouldn't cascade into a frontend error.
@3kt 3kt self-assigned this Jan 24, 2025
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 24, 2025
@3kt 3kt added the Team:Monitoring Stack Monitoring team label Jan 24, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 24, 2025
@3kt 3kt added the >bug label Jan 25, 2025
@TristanAdams03
Copy link

I am experiencing this bug is there a temporary fix until the next patch it is causing my stack to show up as degrading. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants