Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve interface of Inputs in Filebeat #6771

Closed
ph opened this issue Apr 4, 2018 · 2 comments
Closed

Improve interface of Inputs in Filebeat #6771

ph opened this issue Apr 4, 2018 · 2 comments
Labels
enhancement Filebeat Filebeat needs_team Indicates that the issue/PR needs a Team:* label Stalled

Comments

@ph
Copy link
Contributor

ph commented Apr 4, 2018

Input are responsable of taking the inputsource (UDP, TCP, Log) and create the necessary logic and plumbing to get that data out.

Inputs are either persistent like the UDP/TCP or periodically called like the Log inputs, the current interface that all inputs implements is the following one.

type Input interface {
	Run()
	Stop()
	Wait()
}

We can do a few minor improvements:

  • Allow Run()|Stop()|Wait() to return an error, useful in persistent inputs.
  • Maybe Allow inputs to configure by code the frequency of the polling instead of having this done externally.
@botelastic
Copy link

botelastic bot commented Jul 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added Stalled needs_team Indicates that the issue/PR needs a Team:* label labels Jul 9, 2020
@botelastic
Copy link

botelastic bot commented Jul 9, 2020

This issue doesn't have a Team:<team> label.

@botelastic botelastic bot closed this as completed Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Filebeat Filebeat needs_team Indicates that the issue/PR needs a Team:* label Stalled
Projects
None yet
Development

No branches or pull requests

1 participant