Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to load modules from x-pack directory #7524

Closed
webmat opened this issue Jul 5, 2018 · 4 comments
Closed

Need to load modules from x-pack directory #7524

webmat opened this issue Jul 5, 2018 · 4 comments
Labels

Comments

@webmat
Copy link
Contributor

webmat commented Jul 5, 2018

Some of the security analytics modules will come as part of x-pack. There will presumably be more modules that come as part of x-pack in the future.

To make this possible, we will need to look for modules in a new directory. After speaking to @tsg, here's what I know about this:

  • The x-pack modules will be located under x-pack/[beat name]/module
  • It's ok if the x-pack modules get copied to the same directory as the other modules, upon installation.

In order to do this, I'm not sure if we need to do more than add a string to an array, however. Are there other considerations, or other code to modify?

@webmat webmat added the module label Jul 5, 2018
@webmat
Copy link
Contributor Author

webmat commented Jul 6, 2018

Based on the licensing discussions, we may need to split the module in two. Ingestion in OSS and Kibana Objects + ML in x-pack. Just a thing to keep in mind.

@webmat
Copy link
Contributor Author

webmat commented Aug 13, 2018

Foundational work for this is the license check. It's happening here #7946.

@ruflin ruflin added the Team:Integrations Label for the Integrations team label Nov 27, 2018
@alvarolobato
Copy link

Hi @webmat we were reviewing this in our planning. Is there still work to be done here?

@alvarolobato alvarolobato removed the Team:Integrations Label for the Integrations team label Dec 3, 2018
@webmat
Copy link
Contributor Author

webmat commented Dec 3, 2018

No it's pretty much done, as far as I know. Closing.

@webmat webmat closed this as completed Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants